Repository navigation
issue-tracker: implement #89 frontend design - #147
Merged
Merged
Conversation
This was referenced Sep 24, 2026
michielbdejong
added a commit
that referenced
this pull request
Sep 24, 2026
devonian 0.8.0: AtomicIdentityMap.unbind, forget one identity mapping (for #147)
michielbdejong
force-pushed
the
claude/impl-89-issue-tracker
branch
from
September 24, 2026 17:46
4102d0e to
3ce792d
Compare
michielbdejong
pushed a commit
that referenced
this pull request
Sep 24, 2026
The issue-tracker drive app (#147) lists the connected account's repositories and moves a card to Doing by adding or removing the `atomic:doing` label. The pinned GitHub Issues OAD has neither path, so the proxy refused all three calls. - repositories-read-overlay.yaml (new, listed after pagination-overlay): GET /user/repos with per_page/page/sort/direction, the nextLink (Link header) pagination scheme and a narrow `repository` schema. A plain read, not a crudResources collection Reflector would sync. - crud-causality-overlay.yaml: POST .../issues/{n}/labels (JSON body `{labels: [...]}`) and DELETE .../issues/{n}/labels/{name}, declared as partial updates of `issue`. - All three use `repo`, the scope the app already requests; it covers issue labels and private repositories, so the requested scope is unchanged. - Tests: overlay composition test, the default-catalog proxy test (allowed and refused methods/paths, query enum, body rules, scope), and a mock-proxy test through the signed relay. - Mock GitHub fixture: /user/repos with GitHub-style Link headers, and label writes that answer 200 with the label list and 404 for a label the issue lacks, as GitHub does. Shapes follow GitHub's REST reference; not verified against a live account. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
michielbdejong
added a commit
that referenced
this pull request
Sep 24, 2026
overlays: GitHub Issues repository list and issue-label writes (for #147)
michielbdejong
force-pushed
the
claude/impl-89-issue-tracker
branch
from
September 24, 2026 18:46
b1736b6 to
a2bbfa2
Compare
…only (IT-13) GitHubPort writes them into the issue's provenance metadata, next to the author, URL and timestamps it already kept. issuePatch/unproject never read them, so they cannot reach GitHub. No snapshot migration: changed metadata makes the next pass refresh each row's GitHub source once. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…11, IT-14 data side) - Rows carry body, labels, assignees, GitHub times and URL, and their comments (Messages in the app's comments folder), for cards and detail. - edit/comment/create write into the table through the same frame store and overlay the Bridge uses, show the change at once, then run a pass that holds the GitHub write for review. Table writes and passes run one at a time; an edit made during a pass stays on screen until a pass saw it. - Bridge.describeConflict and a per-field Bridge.resolveConflict choice; nothing is written to either side until the next pass. - listRepositories: GET /user/repos through the relay (paged, 5 x 100), outside the Bridge; any failure falls back to typing owner/name. The mock GitHub fixture answers it. - View prefs (layout, search, label) persist in the app's sync state, per installation; a null-origin frame has no storage of its own. - classify() names why a pass paused (uncertain, missing, rejected). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… (IT-2) KIT_CSS aliases the host's --t-* theme variables to --pl-* (plus the derived --pl-hairline and --pl-on-accent, and the --pl-pos fallback, the only literal colours) and styles the header, sync pill, connection bar, banner, empty state, buttons, segmented control, search field, label chip and status glyph from mockups.html. kit.ts builds them as plain DOM; theme.ts injects one <style>, sets data-size from the frame width and data-pl-scheme from the host background (never prefers-color-scheme). Kept inside this plugin, separate from the issue views, so it can move to a shared package once the maintainer decides. vitest now also picks up app/**/*.test.ts (the kit's jsdom tests). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…IT-7, IT-8, IT-9, IT-10, IT-11, IT-14) Replaces the status-line view with the designed screens (DESIGN.md, mockups.html): - Source choice (GitHub; Jira and Todoist shown as not available), repository picker with the write-back effects, host-cannot-relay state. - Board (three columns, counts, Done collapsed to 20, skeleton on first import, drag, 1/2/3 keys and a Move to… menu with a live region) and list (grouped, Done collapsed, status glyph menu); board at >= 720 px, list below, an explicit B/segmented choice wins. - Detail: docked >= 1000 px, drawer 600-999, sheet < 600 with focus trap and focus return; title (Enter saves, Esc reverts), status control, read-only labels, Write/Preview description with a safe Markdown preview (DOM only, no raw HTML), comments with GitHub logins, composer, provenance footer. New issue (N, header, column +) in the same panel. - Sync pill, connection bar, one banner per problem (reconnect, conflict, uncertain write, missing record, Atomic refused); transient failures only on the pill with Retry now and a 4..60 min retry while open. role=alert only for a banner a sync raised in this view. - Conflict review per field (Here / On GitHub, differing text marked); Apply stays disabled until each field has a side. - Search, label filter, count, both empty states, ? shortcut overlay; layout and filters persist on the app's sync state. - Local edits keep the existing review-before-send rule: cards show Waiting to send, and Review and send lists exactly what goes out. - A paused or failed pass still shows the table's rows. The bundle is about 200 KB unminified; build.test's guard moves from 128 to 256 KB. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The spec's connect and consent steps are unchanged. After them it picks the repository from the list (the mock fixture now answers GET /user/repos), checks the board, reloads, sends a reviewed close, settles a title conflict in the review panel, moves a card with the 3 key and adds a comment, each sent after review. The connection bar's tooltip carries the last pass in full, which the spec reads. build.mjs minifies (the one allowed build change), which keeps the bundle under build.test's 128 KB guard (about 123 KB). The live region's object key is renamed so the bundle never matches the node: check. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…quest refusals listRepositories applies proxyRefusal like relayDispatch, so a refused connection reads as one. A signature, capability or access refusal pauses sync with the code in Details instead of retrying on a timer. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- The stylesheets move to app/ui/kit.css and app/styles.css, imported as text (`?raw`); build.mjs runs them through esbuild's CSS minifier before embedding. Vitest reads them with css: true. - build.test's limit is the measured 125,472 bytes plus 10%, rounded up to 135 KiB, with the reason in a comment. - oxlint/oxfmt (atomic-server's browser config) fixes: padding lines, an unused import and parameter, a shadowed name. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- Links (Open on GitHub, Check on GitHub, links in descriptions) open through store.openExternal, which shows the destination first; window.open stays as the fallback on older hosts. - --pl-pos is the host's --t-color-success (the literal is a fallback). - Light/dark comes from store.getTheme()/onThemeChange(); the background luminance is the fallback. - "Disconnect GitHub" in the connection menu: store.proxy.disconnect takes this app's delegation off; the table stays. Disabled where the host lacks it. - frameStore reads the rows a query lists with store.getMany, 100 at a time, each used for one read only. All feature-detected; fakeStore gains the calls (hostApis option) and tests cover each, with and without them. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… from GitHub (IT-12) State 13 now has its two ways out; neither sends anything to GitHub. - Bridge.keepLocalOnly unbinds the issue's (and its comments') GitHub identity and marks the record local-only, so no pass recreates it on GitHub and a stale number column never binds it back. If the issue shows up on GitHub again it binds back to the same record, and the row is written once so its number returns. - Bridge.forget unbinds both sides and drops the record and its comments' records; the app deletes the row and its comment Messages. If the issue returns it is imported again. - A pass that stops on "Missing … record" names the record, its side and row; the banner offers both actions for an issue missing on GitHub, with an inline confirmation before removal. - fakeStore now honours remove() on save, as view-client.js does. Uses AtomicIdentityMap.unbind (devonian 0.8.0, #152). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…e 13 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…call CI's oxfmt --check and e2e spec typecheck. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Drops this branch's own /user/repos handler: #151's wrapper in the same file serves it with GitHub's Link header, and the label writes. The repository list now follows rel="next" (a short page ends it only when there is no Link header), and fakeStore passes relayed headers on, lower-cased. New tests: the Doing move adds and removes atomic:doing against #151's label routes, and listing follows Link paging. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
michielbdejong
force-pushed
the
claude/impl-89-issue-tracker
branch
from
September 25, 2026 07:25
a2bbfa2 to
4bfd229
Compare
michielbdejong
marked this pull request as ready for review
September 25, 2026 07:29
michielbdejong
pushed a commit
that referenced
this pull request
Sep 25, 2026
…rive apps The #89 frontends (#144-#147) as catalog drive apps, through the #111 GitHub Pages flow: - app/build.mjs pins esbuild's absWorkingDir to the repository root, as pets' does. The minified bytes did not change. - Versions: new private app/package.json for timesheets and calendar (0.1.0); issue-tracker's app/package.json (0.1.0); notion keeps its certified package's 0.1.0. - apps/<id>/0.1.0/ui.js and app-module/app-module-integrity written by `apps.mjs write`. - Card copy rewritten for the drive apps as they are now, hedged: all mock-tested only. Clockify loses the LocalThought `platform: clockify` flow text. `devonian-google-calendar` becomes `calendar` (an app entry's shortname is its folder) and loses requires-api-plugins; notion loses requires-api-plugins and callback-platform and is enabled; GitHub issues gets its first entry. All experimental. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
michielbdejong
pushed a commit
that referenced
this pull request
Sep 25, 2026
…apps - READINESS.md: the Clockify, GitHub issues, Google Calendar and Notion drive app rows as they are after #144-#147 and the catalog install (#89 UIs, what each writes, what the host E2E covers, and that none has a live run of the app; Clockify's mock follows the API behaviour checked live for #123). "Drive apps" and the Integrations page facts describe the Drive apps section (atomic-server#1689, in the pin). The Pets drive app row loses its stale "test-side install" and #94 blocker. - lanes.json: calendar, issue-tracker, notion, pets and timesheets notes say the e2e installs from the catalog; timesheets' "test-side until #94" is gone. - READMEs: install from the catalog and how a release is written; the timesheets "What still has to happen" list (install, Disconnect and links are done; M3/M4 writes and live evidence remain); issue-tracker's state 13 ("Keep here only"/"Remove from board") now exists, "It landed" is #156; calendar's entry is `calendar` now. - catalog.json's ontology description: the host renders cards for app entries. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
michielbdejong
pushed a commit
that referenced
this pull request
Sep 25, 2026
…rive apps The #89 frontends (#144-#147) as catalog drive apps, through the #111 GitHub Pages flow: - app/build.mjs pins esbuild's absWorkingDir to the repository root, as pets' does. The minified bytes did not change. - Versions: new private app/package.json for timesheets and calendar (0.1.0); issue-tracker's app/package.json (0.1.0); notion keeps its certified package's 0.1.0. - apps/<id>/0.1.0/ui.js and app-module/app-module-integrity written by `apps.mjs write`. - Card copy rewritten for the drive apps as they are now, hedged: all mock-tested only. Clockify loses the LocalThought `platform: clockify` flow text. `devonian-google-calendar` becomes `calendar` (an app entry's shortname is its folder) and loses requires-api-plugins; notion loses requires-api-plugins and callback-platform and is enabled; GitHub issues gets its first entry. All experimental. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
michielbdejong
pushed a commit
that referenced
this pull request
Sep 25, 2026
…apps - READINESS.md: the Clockify, GitHub issues, Google Calendar and Notion drive app rows as they are after #144-#147 and the catalog install (#89 UIs, what each writes, what the host E2E covers, and that none has a live run of the app; Clockify's mock follows the API behaviour checked live for #123). "Drive apps" and the Integrations page facts describe the Drive apps section (atomic-server#1689, in the pin). The Pets drive app row loses its stale "test-side install" and #94 blocker. - lanes.json: calendar, issue-tracker, notion, pets and timesheets notes say the e2e installs from the catalog; timesheets' "test-side until #94" is gone. - READMEs: install from the catalog and how a release is written; the timesheets "What still has to happen" list (install, Disconnect and links are done; M3/M4 writes and live evidence remain); issue-tracker's state 13 ("Keep here only"/"Remove from board") now exists, "It landed" is #156; calendar's entry is `calendar` now. - catalog.json's ontology description: the host renders cards for app entries. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
michielbdejong
pushed a commit
that referenced
this pull request
Sep 29, 2026
…rive apps The #89 frontends (#144-#147) as catalog drive apps, through the #111 GitHub Pages flow: - app/build.mjs pins esbuild's absWorkingDir to the repository root, as pets' does. The minified bytes did not change. - Versions: new private app/package.json for timesheets and calendar (0.1.0); issue-tracker's app/package.json (0.1.0); notion keeps its certified package's 0.1.0. - apps/<id>/0.1.0/ui.js and app-module/app-module-integrity written by `apps.mjs write`. - Card copy rewritten for the drive apps as they are now, hedged: all mock-tested only. Clockify loses the LocalThought `platform: clockify` flow text. `devonian-google-calendar` becomes `calendar` (an app entry's shortname is its folder) and loses requires-api-plugins; notion loses requires-api-plugins and callback-platform and is enabled; GitHub issues gets its first entry. All experimental. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
michielbdejong
pushed a commit
that referenced
this pull request
Sep 29, 2026
…apps - READINESS.md: the Clockify, GitHub issues, Google Calendar and Notion drive app rows as they are after #144-#147 and the catalog install (#89 UIs, what each writes, what the host E2E covers, and that none has a live run of the app; Clockify's mock follows the API behaviour checked live for #123). "Drive apps" and the Integrations page facts describe the Drive apps section (atomic-server#1689, in the pin). The Pets drive app row loses its stale "test-side install" and #94 blocker. - lanes.json: calendar, issue-tracker, notion, pets and timesheets notes say the e2e installs from the catalog; timesheets' "test-side until #94" is gone. - READMEs: install from the catalog and how a release is written; the timesheets "What still has to happen" list (install, Disconnect and links are done; M3/M4 writes and live evidence remain); issue-tracker's state 13 ("Keep here only"/"Remove from board") now exists, "It landed" is #156; calendar's entry is `calendar` now. - catalog.json's ontology description: the host renders cards for app entries. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For users
Issues: your GitHub issues as a board in your own drive
Issues brings one GitHub repository's issues into your Atomic drive as a board with Todo, Doing and Done columns. You can read, search and update issues right next to your other data. When you move a card, retitle an issue or add a comment, the app shows you exactly what will change on GitHub, and sends it only once you say so. Your collaborators keep working on GitHub as usual.
What you get
How it works
Good to know
atomic:doinglabel on GitHub, and your other labels are left alone. Labels and assignees are shown here but edited on GitHub.For reviewers
Implements the issue-tracker frontend design from #89 (
integrations/issue-tracker/design/, merged in #103). Every change is insideintegrations/issue-tracker/. The branch is rebased onto main after #142 (#54 phase 2), #151 (overlays), #152 (devonian 0.8.0), #154 (pin007869464) and #155; main now pins69602364b(candidate6), which this branch is tested on.Refs #89. It does not close #89, which also covers the other four apps.
What is done (issues.md items)
--pl-*tokens + shared chromeapp/ui/:kit.css(the tokens and chrome styles),kit.ts(header, pill, connection bar, banner, empty state, buttons, segmented control, search field, chip, status glyph, live region),theme.tsanddom.ts. Nothing in it is specific to issues, so it can move to a shared kit later.app/transport.ts, now #142's version. I only extended it withlistRepositories.app/frameStore.ts.GET /user/reposthroughstore.proxy.request(paged, 5 × 100). Repositories withhas_issues: falseare disabled, and the counts are labelled "about N open issues". The effects list shows before import. If listing fails, the app asks forowner/nameinstead (see "Needs outside").1/2/3or the "Move to…" menu, announced in a polite live region. Moving is disabled until the first pass completes. Columns scroll with snap at 720–999 px.Bor the toggle) wins at every width. Below 600 px the header is compact and hit targets are 44 px.N, the header button or a column's+. Gap: there is no control yet for editing an existing comment.background.mjsstill isn't used (the frame has no locks or storage). The pill and banners map from the controller's problem classification. Transient failures show only on the pill, with a "Retry now" popover and a 4 → 60 min retry while the view is open.role="alert"is used only for a banner a sync raised in this view.Bridge.describeConflict, andBridge.resolveConflictnow also takes a per-field{ field: side }. The review panel shows Here / On GitHub for each field with the difference marked. "Apply and resume sync" stays disabled until every field has a side, and nothing is sent before Apply.Bridge.keepLocalOnly: unbinds the GitHub identity with devonian 0.8.0'sAtomicIdentityMap.unbind, marks the record local-only so no pass recreates it on GitHub, clears the issue-number column; if the issue reappears it binds back to the same row and its number is written again) and "Remove from board" (Bridge.forget+ deleting the row and its comment Messages, after an inline confirmation; if the issue reappears it is imported again). Neither sends anything to GitHub (tested). State 12: "Send again" for an unconfirmed update. The exception is "It landed" for an uncertain create, left as a follow-up (the owner is filing an issue for it): the journal refuses to resend the create and the banner says so, but marking it landed needs a way to name the GitHub issue it became, which the design leaves open.issueExtras()in the lens.GitHubPortwrites these into the row's provenance metadata. They are read-only and never part ofissuePatchorunproject(tested). No snapshot migration: each row's source metadata is refreshed once on the next pass.?overlay. Shortcuts don't fire while a text field has focus. Layout and filters persist per installation on the app's sync resource, not in frame storage. That is the owner's "small resource under the app's own data" pattern, and it syncs across devices.3and adds a comment. The lane already listed this spec;lanes.jsonis untouched.--pl-posfallback.Decisions I made
review.mjs) holds every GitHub write until a person approves it. I kept that boundary. Edits show "Waiting to send", and "Review and send" in the connection bar lists exactly what goes out, then "Send N changes to GitHub". Dropping the gate should be your call, not an overnight change.@login, because reading the login would needGET /userthrough the proxy.007869464, all feature-detected: links (Open on GitHub, Check on GitHub, links in descriptions) go throughstore.openExternal;--pl-posisvar(--t-color-success, …); light/dark comes fromstore.getTheme()/onThemeChange()(background luminance only on older hosts), neverprefers-color-scheme; "Disconnect GitHub" in the connection menu callsstore.proxy.disconnect(the table stays);frameStorereads the rows a query lists withstore.getMany, 100 at a time.readRows), so a reload into a paused sync never shows an empty board.minify: true, and the stylesheets moved to.cssfiles thatbuild.mjsruns through esbuild's CSS minifier before embedding. The measured size is 125,472 bytes, and the limit is set to 135 KiB (measured + 10%, rounded up), with a comment inbuild.test.ts.Needs outside this PR
overlays/: resolved by overlays: GitHub Issues repository list and issue-label writes (for #147) #151 (GET /user/reposwith Link paging, and the label paths). This branch dropped its own/user/reposfixture handler for overlays: GitHub Issues repository list and issue-label writes (for #147) #151's. The picker follows theLinkheader, and a unit test checks that the Doing move adds and removesatomic:doingthrough overlays: GitHub Issues repository list and issue-label writes (for #147) #151's label routes.devonian/: resolved by devonian 0.8.0: AtomicIdentityMap.unbind, forget one identity mapping (for #147) #152 (devonian 0.8.0, used here).openExternal,--t-color-success,colorScheme,proxy.disconnectandgetManyare resolved by pin007869464and used. Still open: a per-browser storage op, if you want design decision 1 (host op) instead of the current app-subtree state.integrations/READINESS.md: the GitHub issues row should mention the drive app's new UI. I didn't touch it because it's shared.app/ui/moves to a shared package for the five make sure the main current plugins have a good frontend design #89 apps. That needs your decision.How I tested
node integrations/tooling/run-lane.mjs issue-tracker --tier unit: passed (187 tests, 8 skipped live tests), at pin69602364b.app/controller.test.ts: edits, comments, creates, per-field conflicts, repository paging and fallback, preferences.app/model.test.ts: Done collapse at 0, 20 and 21+; search rules; breakpoints at 380, 700 and 1000 px; each pill and banner state; markers.app/ui/kit.test.ts(jsdom): components, theme tokens, no literal colours, noprefers-color-scheme.app/views.test.ts(jsdom, the realview()overfakeStore): keyboard and menu moves, live region, review and send, detail title save and revert, status change, comment, New issue, focus return, empty states, persistence across views, alert vs no alert, retry pill, conflict Apply.007869464host calls:openExternalfor links,colorSchemeand theme changes,--t-color-success, Disconnect (and disabled without it),getManybatching (fewer reads, same rows).--tier typecheck: passed.build.test.tsalso typechecksapp/.--tier e2e: passed locally against pinned builds11264e83e(0.2 mock proxy) and8270cdf6. Not run locally at007869464or69602364b: there is no built binary for those pins here and Docker isn't running, so CI's e2e job is the check for the current pin.node integrations/tooling/certify.mjs --layer js: money, notion and pets passed (issue-tracker is not a certified package).oxlint and oxfmt with atomic-server's browser config on the changed files: clean.
Visual check: I built the app against
fakeStorewith a 35-issue fixture and the host's light and dark--t-*values frommockups.html, then took Playwright screenshots at the mockups' frame widths:They match mockups 1–10 and 12 in layout, spacing, colours and glyphs. The deliberate differences are the "Review and send" link, "GitHub" instead of
@login, and the not-connected pill. I have no host to upload images to from here, so the screenshots are not attached.🤖 Generated with Claude Code